fix duplication issue in packages_distributions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that @Pive01 raised, where localstack's
/_localstack/extension/listendpoint would fail to list extensions installed in developer mode. I pinned it down to this root cause thatresolve_distribution_informationwould raise aValueError, becauselocalstack-extension-hello-world(for example) would appear twice inpackages_distributions().get("helloworld").As explained in the code doc i added:
With editable installs,
packages_distributions()may return the distribution metadata for both the.egg-infoin the linked source directory, and the.dist-infoin the site-packages directory created by the editable install. Therefore, a distribution name may appear twice for the same package. Subsequently raising a ValueError.