fix entrypoints installation by limiting setuptools compatiblity #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With
setuptools==75.2.0
,plux
has issues when restoring the entrypoints on the installation of source distributions.This is caused by pypa/setuptools#4647, it might be specifically relate to this comment. It definitely is caused by the fact that the
egg_info
command and theegg2dist
is not called anymore.I also tried to dive into this with a hack implemented in ffb1ad9 which will be taken over by @thrau.
In LocalStack, we are mitigating this issue by introducing a limit in the
build-system.requires
: localstack/localstack#11715However, this only fixes the issue in upcoming releases, the source distributions out there won't be affected by this change.
This is why plux itself should declare that it is not compatible with the latest release of
setuptools
.Changes
This PR introduces
setuptools
as an install dependency (which it is and always was) and limits the version to<=75.1.0
(which is the latest compatible version).This change can be reverted as soon as
plux
is compatible with the latest version ofsetuptools
again.Testing
I verified that this fix by executing the following steps / scripts: