Skip to content

Fix truncated float scores #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mockredis/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,11 @@ def _range_func(self, withscores, score_cast_func):
Return a suitable function from (score, member)
"""
if withscores:
return lambda score_member: (score_member[1], score_cast_func(str(score_member[0])))
if score_cast_func == float:
# don't cast to string first or it will truncate the float, see #58
return lambda score_member: (score_member[1], score_cast_func(score_member[0]))
else:
return lambda score_member: (score_member[1], score_cast_func(str(score_member[0])))
else:
return lambda score_member: score_member[1]

Expand Down
15 changes: 15 additions & 0 deletions mockredis/tests/test_zset.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ def test_zscore_int_member(self):
self.redis.zadd(key, 1, 1.0)
eq_(1.0, self.redis.zscore(key, 1))

def test_zscore_float_member(self):
key = "zset"
eq_(None, self.redis.zscore(key, 1))

self.redis.zadd(key, 1, 1.2345678901234)
eq_(1.2345678901234, self.redis.zscore(key, 1))

def test_zrank(self):
key = "zset"
eq_(None, self.redis.zrank(key, "two"))
Expand Down Expand Up @@ -313,6 +320,14 @@ def test_zremrangebyscore(self):
eq_([], self.redis.zrange(key, 0, -1))
eq_([], self.redis.keys("*"))

def test_zrange_float_scores(self):
"""
Make sure zrange doesn't truncate our floats, see #58
"""
key = "zset"
self.redis.zadd(key, "long", 1.2345678901234)
eq_([("long", 1.2345678901234)], self.redis.zrange(key, 0, -1, withscores=True))

def test_zunionstore_no_keys(self):
key = "zset"

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

# Match releases to redis-py versions
__version__ = '2.9.0.7'
__version__ = '2.9.0.8'

# Jenkins will replace __build__ with a unique value.
__build__ = ''
Expand Down