Sigmoidal Contrast #1681
Sigmoidal Contrast #1681
Conversation
jamesmcclain
force-pushed
the
feature/jamesmcclain/sigmoidal-contrast
branch
4 times, most recently
from
de11bcc to
a59a04c
Compare
|
There's a checkbox on the "Still needs" missing, is this ready to go? |
@lossyrob No, I still need unit tests for the RDD case. I am writing those right now. |
jamesmcclain
force-pushed
the
feature/jamesmcclain/sigmoidal-contrast
branch
from
a59a04c to
32deaad
Compare
|
Okay, unit tests have been added. |
| * @return The output tile | ||
| */ | ||
| def apply(tile: Tile, alpha: Double, beta: Double): Tile = { | ||
| val T = _T(tile.cellType, alpha, beta)_ |
There was a problem hiding this comment.
upper-case vals go against Scala style norms. Is there a specific reason to use it here?
|
|
||
| private def _T( | ||
| cellType: CellType, alpha: Double, beta: Double | ||
| )(_u: Double): Double = { |
There was a problem hiding this comment.
using an underscore in a param name is out of normal scala style - is there reason to use it? Could we replace this with a longer, more descriptive name instead?
| def multiband[K, V: (? => MultibandTile): ClassTag, M]( | ||
| rdd: RDD[(K, V)] with Metadata[M], | ||
| alpha: Double, beta: Double | ||
| ): RDD[(K, MultibandTile)] with Metadata[M] = { |
There was a problem hiding this comment.
Do these need the Metadata? or could we just make these methods on RDD[(K, MultibandTile)]? We want to create methods on the least-specified versions (only asking for type restrictions that we need) so that we can utilize this for as broad of a range of use cases as possible. For instance, could we run this on source tiles of type RDD[(ProjectedExtent, MultibandTile)]?
There was a problem hiding this comment.
Okay, I will give that a try.
|
I think that all comments prior to this one have been addressed. |
Still needs:
Original:
Imagemagick (
convert -sigmoidal-contrast 10,50%):This PR (with alpha=0.5 and beta=10):
