Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter GeoTiffRDDs by Geometry #2409

Merged
merged 4 commits into from
Oct 13, 2017

Conversation

jamesmcclain
Copy link
Member

@jamesmcclain jamesmcclain commented Oct 5, 2017

bucket: String, prefix: String,
uriToKey: (URI, I) => K,
options: Options,
geometry: Option[Geometry] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, mb to add some helpful overloads? Though it's smth to discuss, as the best otpion would be to move it into Options and it's impossible due to compatibility reasons. ):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also needs to be an apply with the old signature to avoid removing this method from the API.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mb in 2.0 we'll move geometry into Options but for now it's good. Looks like it can be merged as is after #2402

Review TIP

@pomadchin
Copy link
Member

Btw a thought appeared after the review: mb it makes sense to add some extra overloads to use this filter by geometry functionality more convenient.

@jamesmcclain
Copy link
Member Author

jamesmcclain commented Oct 11, 2017

Btw a thought appeared after the review: mb it makes sense to add some extra overloads to use this filter by geometry functionality more convenient.

Yes, perhaps we can do that in a subsequent PR (or not, depending on timing).

@jamesmcclain jamesmcclain force-pushed the feature/geotiff-filtering branch from 4fb92b2 to bbd21aa Compare October 11, 2017 16:37
@rossbernet rossbernet added this to the 1.2 milestone Oct 11, 2017
@jamesmcclain jamesmcclain force-pushed the feature/geotiff-filtering branch from bbd21aa to 10ec91f Compare October 11, 2017 19:42
bucket: String, prefix: String,
uriToKey: (URI, I) => K,
options: Options,
geometry: Option[Geometry] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also needs to be an apply with the old signature to avoid removing this method from the API.

@jamesmcclain jamesmcclain force-pushed the feature/geotiff-filtering branch from 10ec91f to c33e89b Compare October 12, 2017 13:39
@echeipesh echeipesh merged commit e88c094 into locationtech:master Oct 13, 2017
@jamesmcclain jamesmcclain deleted the feature/geotiff-filtering branch November 17, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants