GeoTrellisRasterSource should return None on empty reads #3240
Conversation
pomadchin
force-pushed
the
fix/sparsed-stich
branch
from
9e78875 to
3e791a9
Compare
| tiles: Seq[(SpatialKey, MultibandTile)] with Metadata[TileLayerMetadata[SpatialKey]], | ||
| extent: Extent | ||
| ): Option[Raster[MultibandTile]] = { | ||
| val md = tiles.metadata |
There was a problem hiding this comment.
There was no tiles.isEmpty check, and anyway we don't need this function anymore, see #2903
There was a problem hiding this comment.
Can you comment a bit further on why we don't need this anymore? That linked issue + its links don't show where the original problem handling missing spatialkeys is addressed in the original sparsestitch function.
There was a problem hiding this comment.
@CloudNiner if you will look a bit above (at the place where it was used):
sparseStitch(tiles, extent) we can use the inbuilt function now tiles.sparseStitch(extent)
The issue #2903 was addressed in your PR here #3017 which is called "Add sparse stitch method to StitchCollectionMethods".
There was a problem hiding this comment.
lol embarrassing -- I do in fact remember this now. 👍
| tiles: Seq[(SpatialKey, MultibandTile)] with Metadata[TileLayerMetadata[SpatialKey]], | ||
| extent: Extent | ||
| ): Option[Raster[MultibandTile]] = { | ||
| val md = tiles.metadata |
There was a problem hiding this comment.
Can you comment a bit further on why we don't need this anymore? That linked issue + its links don't show where the original problem handling missing spatialkeys is addressed in the original sparsestitch function.
pomadchin
force-pushed
the
fix/sparsed-stich
branch
from
f186d03 to
c5635bd
Compare
pomadchin
force-pushed
the
fix/sparsed-stich
branch
from
c5635bd to
42c94b4
Compare
Overview
This PR removes a duplicate
GeoTrellisRasterSource.sparseStitchfunction that also was not safe enough and could work (incorrectly) with empty inputs.Checklist
Notes
This bug was revelaed during this issue investigation.