JTS 1.18, GeoTools 25.0 #3437
JTS 1.18, GeoTools 25.0 #3437
Conversation
| @@ -780,6 +782,8 @@ case class PointResult(geom: Point) extends GeometryResult | |||
| with MultiLineStringMultiLineStringDifferenceResult | |||
| with MultiPointMultiPointDifferenceResult | |||
| with MultiPolygonMultiPolygonDifferenceResult | |||
| with MultiPointMultiPolygonUnionResult | |||
| with MultiPointMultiLineStringUnionResult | |||
There was a problem hiding this comment.
Paging @jpolchlo -- seems like JTS got a bit better at simplifying the results of union. I was pretty mechanical about this, could use your 👀 as the vector master.
There was a problem hiding this comment.
Happy to look. Got any specific concerns? These Result types are pretty labyrinthine.
| @@ -79,7 +79,7 @@ object RDDPolygonalSummary { | |||
| val extent: Extent = layout.mapTransform.keyToExtent(spatialKey) | |||
| val raster: Raster[T] = Raster(tile, extent) | |||
| val result: PolygonalSummaryResult[R] = | |||
| raster.polygonalSummary(feature.geom, visitor.getClass.newInstance, options) | |||
| raster.polygonalSummary(feature.geom, visitor.getClass.getDeclaredConstructor().newInstance(), options) | |||
There was a problem hiding this comment.
@echeipesh what is the difference?
There was a problem hiding this comment.
https://docs.oracle.com/javase/9/docs/api/java/lang/Class.html#newInstance--
Deprecated. This method propagates any exception thrown by the nullary constructor, including a checked exception. Use of this method effectively bypasses the compile-time exception checking that would otherwise be performed by the compiler. The Constructor.newInstance method avoids this problem by wrapping any exception thrown by the constructor in a (checked) InvocationTargetException.
|
🚀 |
|
UPD: we don't need PB CQs. |
Overview
Version bumps to fantastic OverlayNG
Errors in:
CQs:
Checklist
docsguides update, if necessaryCloses #3436