Improve LineStringSnapper performance by using squared distance #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove empty seg object Signed-off-by: Michael Carleton <micycle1@hotmail.co.uk>
micycle1
changed the title
LineStringSnapper Performance Improvement
|
Looks good, thanks. I might do a bit of renaming/refactoring as a followup to this PR. |
dr-jts
changed the title
LineStringSnapper Performance Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #1110.
commit 1 - we get a ~10% increase by removing assignments to the
segobject and working with coordinates directly.commit 2 - a further ~15% increase vs sqrt-based distance. Does add to the public API (because different package access required) which might not be desirable
(Also, I'm sure there are a lot of other code areas that could benefit from the same approach -- working with squared distances and avoiding
sqrt()).