Bug fixed for EquidistantAzimuthalProjection #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the back side of the earth. Signed-off-by: wyq <yaqiang.wang@gmail.com>
|
Hey @Yaqiang that's pretty nice, thank you. However, I'm a bit hesistant to add an extra dep to the zero dependencies library. 🤔 |
|
A possible solution is to copy the code from geographiclib-java into proj4j, just like OSGeo PROJ which transcripted the geographiclib c++ code (https://github.com/OSGeo/PROJ/blob/master/src/geodesic.c). |
|
I will try to re-commit the PR by adding geodesic code in proj4j. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EquidistantAzimuthalProjection, project and projectInverse functions results are not corrected with elliptical OBLIQUE or EQUATOR setting #84. Geodesic calculation is needed in this condition, which can be done using GeographicLib-Java dependency (https://github.com/geographiclib/geographiclib-java). Also I added testEquidistantAzimuthal function for testing, and it passed.