Added forced truncation of WKT types in Markdown/HTML rendering. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
commented
Nov 5, 2019
| @@ -47,8 +49,9 @@ trait DataFrameRenderers { | |||
| lit("\"></img>") | |||
There was a problem hiding this comment.
Wondering if the line above this one
base64(rf_render_png(rf_resample(resolved, 0.5), ColorRamps.Viridis))
should be changed to use ColorRamps.greyscale(256), and then apply a color ramp in the python API for notebooks.
There was a problem hiding this comment.
I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk
There was a problem hiding this comment.
Good point. Damn. Didn't think of that.
vpipkt
suggested changes
Nov 6, 2019
| @@ -47,8 +49,9 @@ trait DataFrameRenderers { | |||
| lit("\"></img>") | |||
There was a problem hiding this comment.
I guess I am not sure about what we can do on the notebook / python side if the image is already b64 encoded in HTML... Some css stuff? idk
vpipkt
approved these changes
Nov 6, 2019
|
🚢 it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407