Fix st_reproject throws on encountering null value in column #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasim
suggested changes
Mar 10, 2021
| val geom = JTSTypes.GeometryTypeInstance.deserialize(geometry.eval(input)) | ||
| JTSTypes.GeometryTypeInstance.serialize(reproject(geom, src, dst)) | ||
| } | ||
| null |
There was a problem hiding this comment.
Why do you always evaluate to null here... should this be in an else?
There was a problem hiding this comment.
Oops. you're right.
Fix that
Author: Netanel Malka <netanel246@gmail.com> st_reproject throws on encountering null value in column - locationtech#501 Added null check on ReprojectGeometry Signed-off-by: Netanel Malka <netanel246@gmail.com>
netanel246
force-pushed
the
fix_st_reproject_null_bug
branch
from
0fbcad7
to
05877c7
Compare
metasim
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Netanel Malka netanel246@gmail.com
st_reproject throws on encountering null value in the column - #501
Added null check on ReprojectGeometry
Added test for that
Signed-off-by: Netanel Malka netanel246@gmail.com