Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDTs registration ordering #573

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Nov 9, 2021

Without this fix workers may try to access Encoders before registering UDTs.

Tested both 66cca65 and 8b5c165 within the k8s notebook.

The image to play with is quay.io/daunnc/rasterframes-notebook:0.10.1-SNAPSHOT

@@ -140,7 +140,7 @@ def dest_file(self, src_file):
# to throw a `NotImplementedError: Can't perform this operation for unregistered loader type`
pytest = 'pytest>=4.0.0,<5.0.0'

pyspark = 'pyspark==3.1.1'
pyspark = 'pyspark==3.1.2'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how it worked before 🤦

@@ -1,4 +1,4 @@
pyspark>=3.1
pyspark==3.1.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark 3.2 has been released and we need more strict constraints here.

@echeipesh
Copy link
Contributor

Screen Shot 2021-11-10 at 8 40 43 AM

Whats up with the CI failure here? Have you seen something like this? (Hey Google)

@metasim
Copy link
Member

metasim commented Nov 10, 2021

@pomadchin Do you know why the difference between 3.1.1 and 3.1.2 made a difference?

@metasim
Copy link
Member

metasim commented Nov 10, 2021

@pomadchin @echeipesh What do you think about sticking with CircleCI until we have time to figure out GitHub actions?

Copy link
Member

@metasim metasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pomadchin !

@pomadchin
Copy link
Member Author

@metasim Nope don't know, I noticed that even minor spark version mismatch on a driver and workers may cause to fail even jobs scheduling. I dont know why it worked before 🦐 but worked: I guess it matters what spark version is installed on a host and it 'just works'.

@metasim
Copy link
Member

metasim commented Nov 10, 2021

I dont know why it worked before 🦐 but worked: I guess it matters what spark version is installed on a host and it 'just works'.

Maybe only triggered in cluster mode ¯_(ツ)_/¯

@pomadchin pomadchin merged commit bb43a93 into locationtech:develop Nov 10, 2021
@pomadchin pomadchin deleted the fix/udt-registration branch November 10, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants