Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix. #582

Merged
merged 3 commits into from
Jun 14, 2022
Merged

CI fix. #582

merged 3 commits into from
Jun 14, 2022

Conversation

metasim
Copy link
Member

@metasim metasim commented Apr 7, 2022

Addresses this.

@metasim metasim requested a review from pomadchin April 7, 2022 13:23
@metasim
Copy link
Member Author

metasim commented Apr 7, 2022

@pomadchin it seems CircleCI integration has disappeared. Have you seen this elsewhere? Not sure what happened.

@pomadchin
Copy link
Member

pomadchin commented Apr 7, 2022

@metasim yea, so I think it is a change in the default checks settings for all github projects. The way to fix it is to go to cricle Organization Settings => VSC => Manage GitHub Checks

i.e.
image

@pomadchin
Copy link
Member

pomadchin commented Apr 7, 2022

That sounds like we need to file an ipzilla ticket ._.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also bump the GT version up and STAC4s (it contains a serious pagination related improvement)?

It can also be a separate PR though.

@metasim metasim merged commit 1e314ea into locationtech:develop Jun 14, 2022
@metasim metasim deleted the fix/ci-issue branch June 14, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants