Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointLatLon convenience method #165

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Conversation

MoeweX
Copy link
Contributor

@MoeweX MoeweX commented Aug 27, 2018

This pull requests adds a pointLatLon convenience method as proposed in #164 .

I also noticed that the project cannot be build with Maven and Java 9 due to the error described here. Thus, I bumped the JaCoCo plugin version to 0.8.2 which is the newest one available.

EDIT: I can squash the commits if necessary.

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #165 into master will increase coverage by 0.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
+ Coverage     75.14%   75.15%   +0.01%     
+ Complexity     1096     1093       -3     
============================================
  Files            57       57              
  Lines          3794     3800       +6     
  Branches        772      772              
============================================
+ Hits           2851     2856       +5     
- Misses          664      667       +3     
+ Partials        279      277       -2
Impacted Files Coverage Δ Complexity Δ
...rg/locationtech/spatial4j/io/OnePointsBuilder.java 42.85% <0%> (-11.69%) 4 <0> (ø)
...ationtech/spatial4j/shape/jts/JtsShapeFactory.java 87.93% <0%> (-0.45%) 55 <0> (ø)
...iontech/spatial4j/shape/impl/ShapeFactoryImpl.java 81.31% <42.85%> (-2.02%) 39 <1> (+2)
.../locationtech/spatial4j/shape/jts/JtsGeometry.java 77.77% <0%> (+0.35%) 80% <0%> (+1%) ⬆️
...locationtech/spatial4j/distance/DistanceUtils.java 69.75% <0%> (+0.42%) 50% <0%> (ø) ⬇️
...java/org/locationtech/spatial4j/io/ParseUtils.java 28.3% <0%> (+1.02%) 6% <0%> (ø) ⬇️
...va/org/locationtech/spatial4j/io/GeohashUtils.java 88.6% <0%> (+2.18%) 28% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbc615b...45f0b4b. Read the comment docs.

@MoeweX MoeweX force-pushed the master branch 2 times, most recently from 89a09e0 to bc7c59b Compare August 27, 2018 07:30
@MoeweX
Copy link
Contributor Author

MoeweX commented Aug 27, 2018

I am not to sure about fb5aa6b, but I think it makes sense to add getLat and getLon to Point as well.

@dsmiley
Copy link
Contributor

dsmiley commented Aug 27, 2018

Looks good to me! Thanks. Please do squash to two commits -- one for jacoco and the other for the rest.

MoeweX added 2 commits August 28, 2018 08:27
Signed-off-by: MoeweX <Jonathan@Hasenburg.de>
Signed-off-by: MoeweX <Jonathan@Hasenburg.de>
@MoeweX
Copy link
Contributor Author

MoeweX commented Aug 28, 2018

Thx @dsmiley , I squashed the commits.

@dsmiley dsmiley merged commit fd860ad into locationtech:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants