externalized strings and added translation into german #307
Conversation
Signed-off-by: sloob <sebastian.loob@ibykus.de>
| @@ -0,0 +1,233 @@ | |||
|
|
|||
There was a problem hiding this comment.
Just as a hint, We setup a Translation project at Transifex : https://www.transifex.com/udig/udig/dashboard/ where normally resources of origin language (English) synchronized.
However for messages_de.properties I'd suggest to add only keys that are translated already (into German). Here again helps Transifex a lot to get a translation state (in %) any synchronizing translated property files back into codebase.
For this ressource you may have a look at https://www.transifex.com/udig/udig/viewstrings/#de/udig_tools-messages/17409421
There was a problem hiding this comment.
If you need help to synchronize German resources, installed Transifex tool installed the Ant-Script transifex-sync.xml can help in combination with resource configuration file down below .tx folder : https://github.com/locationtech/udig-platform/blob/master/.tx/config to pull translated message files for a specific languages (or all languages)
There was a problem hiding this comment.
@sloob Can we remove German i18n file from this changeset. I'd like to apply this change and merge it into master afterwards.
There was a problem hiding this comment.
Hey @fgdrf, i will look at transifex and if necessary add our translations there. Should I make a new commit without the german i18n file or can you omit the file when merging?
There was a problem hiding this comment.
IMO it is quite easy to remove file from commit by using "--amend". This implies to push with "-f" option to rewrite history of your remote branch. I assume nobody else is working on it and therefor it should be a problem.
HTH
There was a problem hiding this comment.
Oh, just spotted a "Delete this file" option at web UI menu of this ressource
I guess this makes it easier than the amend option of git ;)
not all keys are already translated, so this translation will be added later in a separate PR
Externalized some dialog messages and added a translation into german.
Signed-off-by: sloob sebastian.loob@ibykus.de