Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hk] unifies semantic for vertex opacity #326

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

fgdrf
Copy link
Contributor

@fgdrf fgdrf commented Oct 25, 2018

Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net

Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 25, 2018

#313 introduced opacity configuration for edit geometries. This changeset unifies the usage of opacity rather than transparency for internal vars and properties.

@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 25, 2018

Pull Request build started : https://ci.eclipse.org/udig/job/uDig-PR/33/

@fgdrf fgdrf merged commit 85cc227 into locationtech:master Oct 25, 2018
@nprigour
Copy link
Contributor

nprigour commented Oct 26, 2018

Hi @fgdrf ,

Some comments regarding this PR and the interelated #324:

  1. EditToolPreferneces_vertexOpacity is mispelled (not important but anyway :) )
  2. Why did we merge this without updating the udig documentation regarding the new preference option?

@fgdrf
Copy link
Contributor Author

fgdrf commented Oct 26, 2018

@nprigour @sloob Thanks for your input. I haven't seen the typo during the review - however, I'll fix it!

Regarding documentation : Sure, an update of udig-platform/docs/user/en/reference/Edit Tool Preferences.rst makes totally sense. At least the screenshot of https://github.com/locationtech/udig-platform/blob/master/docs/user/en/images/edit_tool_preferences/edittoolpreferences.png

@sloob would you add it, maybe at the end for both pull requests, vertex opacity and fill opacity (#313)?

fgdrf added a commit to fgdrf/udig-platform that referenced this pull request Dec 23, 2019
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants