change visibility of category finder methods in ToolManager to public and made them final #335
Conversation
made them final to prohibit their subclassing. Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
fgdrf
changed the title
|
Good idea, wondering why we should not add these to IToolManager as well. Then there is no need to cast to ToolManager e.g. in ToolProxy anymore.. |
|
Hi @fgdrf, |
|
Providing a pull request for your branch to pull it into interface .. |
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
|
started a build to get feedback https://ci.eclipse.org/udig/job/uDig-PR/40/ |
|
It seems that everything is OK! |
Hmm, not really, The build infrastructure is quite slow and several builds haven't finished successfully. However, on my machine it works, compilation and tests were fine. I'll merge .. Many thanks for your contribution and collaboration! |
|
Indeed it seems that there are some problems with jenkins (or the machine it runs) because I also experienced problems while trying to view the progress of the build! |
… and made them final (locationtech#335) * change visibility of category finder methods in ToolManager to public and made them final to prohibit their subclassing. Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com> * pulls up methods to IToolManager Interface Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
change visibility of category finder methods in ToolMnager to public and made them final to prohibit their subclassing.
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com