Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in the documentation of DifferentialActionModelAbstractTpl #1183

Open
lwygzh opened this issue Nov 16, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@lwygzh
Copy link

lwygzh commented Nov 16, 2023

Hi,

I was reading the documentation of DifferentialActionModelAbstractTpl and I think there might be an error within the documentation. When showing what the cost function for DifferentialActionModelAbstractTpl should describe, it shows that

$$l(x, u) = \int_{0}^{\delta_t}{a(r(x, u))}dt$$

I was wondering if the value of l(x, u) in this case should actually be

$$l(x, u) = a(r(x, u))$$
@lwygzh lwygzh added the bug Something isn't working label Nov 16, 2023
@lwygzh lwygzh changed the title Possible error in documentation Possible error in the documentation of DifferentialActionModelAbstractTpl Nov 16, 2023
@cmastalli
Copy link
Member

cmastalli commented Nov 16, 2023

Yes, you're right! We integrate the cost function in the integrated action. It would be fantastic if you could help us to improve the documentation.

@lwygzh
Copy link
Author

lwygzh commented Nov 17, 2023

Of course, I would be glad to help! I can do a PR with the updated doc.

Just one question, I think the doc for that specific algorithm is located here, but the content of this docstring is a bit different from what is on the website (probably because the version of crocoddyl on the website is 1.9.0 and the master branch is 2.0+). If that is the case, would it be possible to also update the doc version on the website?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants