Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter notebooks #19

Merged
merged 17 commits into from
Dec 9, 2021
Merged

Add jupyter notebooks #19

merged 17 commits into from
Dec 9, 2021

Conversation

pFernbach
Copy link
Member

@pFernbach pFernbach commented Oct 2, 2020

Add 3 notebooks showing basic usages of the API, how to create a Contact Sequence from scratch and how to load it from a file and use the data stored inside to plot/display the motion.

Also add a new constructor to ContactPatch that take a ContactModel as argument.

@pFernbach pFernbach requested a review from nim65s October 2, 2020 14:12
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

I'm a bit late for the review, sorry :)

Everything looks really good, I just made tiny editions for some details.

But I have one error :

matmul: Input operand 1 has a mismatch in its core dimension 0, with gufunc signature (n?,k),(k,m?)->(n?,m?) (size 12 is different from 3)",

Could you check this ?

Also, I would advise to use the "restart kernel & run all cells" before saving a notebook, to check that everything works and have nice numbering of the cells ;)

@nim65s nim65s mentioned this pull request Mar 16, 2021
@nim65s nim65s merged commit b4a2569 into loco-3d:devel Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants