Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #14

Closed
digitv opened this issue Jun 8, 2021 · 3 comments
Closed

PHP 8 support #14

digitv opened this issue Jun 8, 2021 · 3 comments

Comments

@digitv
Copy link
Contributor

digitv commented Jun 8, 2021

Hi! Could you add support of latest PHP version ( ^8.0 ) ?
We are using your SDK in our project ( with Laravel 8) but we couldn't update to the latest PHP.

@StevenAvelino24
Copy link

Would it be possible to release the change made in d8904c8 ?
The package is still not PHP 8 compliant unless we get the master branch

@timwhitlock
Copy link
Member

Can you confirm that the change works for you.

I've only run the phpunit tests under PHP8. It's not tested with Laravel as per the original request.

@digitv
Copy link
Contributor Author

digitv commented Oct 7, 2021

Can you confirm that the change works for you.

I've only run the phpunit tests under PHP8. It's not tested with Laravel as per the original request.

Hi! Package works for our project as good as before on PHP 7.4. Off course we are using not all the functionality, but upload/download/getting_locales seems to be OK, no exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants