Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pages/communities landing page #17

Open
joshdanielson opened this issue Sep 4, 2018 · 9 comments
Open

Create pages/communities landing page #17

joshdanielson opened this issue Sep 4, 2018 · 9 comments
Assignees

Comments

@joshdanielson
Copy link
Contributor

@christinnolasco
Copy link
Collaborator

9 4 18 landing page - community

@christinnolasco
Copy link
Collaborator

Landing Page Logos
Landing Page Logos.zip

@joshdanielson joshdanielson changed the title Create partner-with-us-community-development-organizations landing page Create pages/communities landing page Nov 28, 2018
joshdanielson added a commit that referenced this issue Nov 28, 2018
IagoSRL added a commit that referenced this issue Jan 31, 2019
IagoSRL added a commit that referenced this issue Jan 31, 2019
IagoSRL added a commit that referenced this issue Jan 31, 2019
@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

@joshdanielson I pushed branch is17-community-landing with the three landings (#17 #16 #15) with the placeholder hero title, description and button. Please review if the design and common content is as expected and fill the real data on that properties.

@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

I pushed them to dev that should be shortly available.

joshdanielson added a commit that referenced this issue Jan 31, 2019
@joshdanielson
Copy link
Contributor Author

@IagoSRL just pushed the changes for the higher-education (the one needed for Thursday). Thank you!! I'll work on the others in the next week or so. I had to create a new services.html and would like to tailor these for each landing page so may need specific landing page templates (I should be able to figure this out, though).

I also tried to change the font color on the "Join 90 Days Free" button to white when scrolling with no luck (see my commented out code):
screen shot 2019-01-30 at 8 09 14 pm

@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

I fixed the button color on scroll, and merged to master releasing it to dev and live (pending of deploying completion, should get an auto notice at Slack).

@IagoSRL IagoSRL closed this as completed Jan 31, 2019
@IagoSRL IagoSRL self-assigned this Jan 31, 2019
@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

I had to create a new services.html and would like to tailor these for each landing page so may need specific landing page templates (I should be able to figure this out, though).

Forgot to answer that detail, I removed this issue branch, let me take on adjust the meta data so that's customizable for landings on the next landing issue

@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

Sorry, I little mess managing this, the landing we have ready is the higher-education that has issue #15, so I will close that and re-open this, setting this new task for me:

  • Let's allow customizing services-partners.html from metadata
    • Move current text to higher-education landing metadata
    • Replace fixed text at the partial with the metadata placeholders

@IagoSRL IagoSRL reopened this Jan 31, 2019
IagoSRL added a commit that referenced this issue Jan 31, 2019
higher-education copy to the page definition #17
@IagoSRL
Copy link
Collaborator

IagoSRL commented Jan 31, 2019

OK, refactor the services_partners so copy can be adjusted from the page files, and copied the higher-education content to the other two as example. Pushed to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants