Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint errors in ./dist folder since eslint 9 PR #3461

Closed
corneliusroemer opened this issue Dec 17, 2024 · 1 comment · Fixed by #3462
Closed

Eslint errors in ./dist folder since eslint 9 PR #3461

corneliusroemer opened this issue Dec 17, 2024 · 1 comment · Fixed by #3462
Labels
codesmell For warnings/lints without immediate harm but to be fixed eventually

Comments

@corneliusroemer
Copy link
Contributor

In a directory where I've run npm run build I now get eslint errors since the eslint 9 PR got merged: #3450

/Users/corneliusromer/code/loculus/website/dist/server/chunks/ErrorFeedback_ByRDamcW.mjs
   732:3  warning  Unused eslint-disable directive (no problems were reported)
   922:7  error    Definition for rule 'react/prop-types' was not found            react/prop-types
  1208:5  error    Definition for rule 'react-hooks/rules-of-hooks' was not found  react-hooks/rules-of-hooks

/Users/corneliusromer/code/loculus/website/dist/server/chunks/Pagination_DlSmtfe7.mjs
  75:3  warning  Unused eslint-disable directive (no problems were reported from 'no-nested-ternary')
  80:3  warning  Unused eslint-disable directive (no problems were reported from 'no-nested-ternary')

/Users/corneliusromer/code/loculus/website/dist/server/chunks/useTheme_xLVzobZB.mjs
   615:7  warning  Unused eslint-disable directive (no problems were reported from 'no-restricted-globals')
   692:7  warning  Unused eslint-disable directive (no problems were reported from 'guard-for-in' or 'no-restricted-syntax')
  1412:5  error    Definition for rule 'react-hooks/rules-of-hooks' was not found                                             react-hooks/rules-of-hooks
  1622:5  error    Definition for rule 'react-hooks/rules-of-hooks' was not found                                             react-hooks/rules-of-hooks

/Users/corneliusromer/code/loculus/website/dist/server/pages/seqsets.astro.mjs
   174:5  error    Definition for rule 'react-hooks/exhaustive-deps' was not found  react-hooks/exhaustive-deps
   364:3  warning  Unused eslint-disable directive (no problems were reported)
   449:3  warning  Unused eslint-disable directive (no problems were reported)
  1466:7  error    Definition for rule 'react/prop-types' was not found             react/prop-types
  1895:7  error    Definition for rule 'react/prop-types' was not found             react/prop-types

✖ 14 problems (7 errors, 7 warnings)
  0 errors and 7 warnings potentially fixable with the `--fix` option.
@fhennig
Copy link
Contributor

fhennig commented Dec 17, 2024

I looked at the PR but don't quite understand what the issue was and why the fix works - can you explain? So I don't make the same mistake in the future 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codesmell For warnings/lints without immediate harm but to be fixed eventually
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants