-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): Split mutations by gene (for aa) and segment (for nucs), fix "show more" bug #1811
Conversation
In order to do this I create a segmentedMutations object which maps a segment to a list of all mutations on that segment.
f1a225f
to
34f2937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I was wondering if you want to not include the gene/segment in the badges to make the more concise now that genes/segments are included in the title.
So not show VP35:
in the badges VP35:A13V
. Ideally this would still be what the user copies if they use the clipboard but that's not super important if it's tricky.
Questions:
- What happens for segments/genes without mutations? Are they omitted or do we see lots of headings with no info?
Ok here's the answer: they are just not shown 👍
@corneliusroemer - great idea - think this should be possible with CSS Off-Screen Positioning - I will just need to figure out how to do this with tailwind - I will try to see if I can do this quickly or I will create a follow up issue. Update: tailwind has the screenreader-only class which is intended just for this use case. |
… - this allows the mutations to be searchable with an appended gene name (and will be visible when the amino acid mutations are copied) but it will not be shown on the page.
357bc72
to
6d45fe3
Compare
resolves #1796, resolves #1620
preview URL: https://feat-split-mutations-by-s.loculus.org/
Summary
show more
button for segments that have underMAX_INITIAL_NUMBER_BADGES
and where the button is not required.GP:A83V GP:T263A...
additionally, the page can be searched with appended sequenceName.Screenshot