Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): set node version in dockerfile through arg, align with nvmrc, bump to 22 #1841

Merged
merged 8 commits into from
May 10, 2024
Merged

chore(website): set node version in dockerfile through arg, align with nvmrc, bump to 22 #1841

merged 8 commits into from
May 10, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented May 9, 2024 •
edited
Loading

preview URL: https://node-version-docker.loculus.org

Summary

image

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label May 9, 2024
corneliusroemer
corneliusroemer commented May 9, 2024
View reviewed changes
website/Dockerfile Outdated Show resolved Hide resolved
@corneliusroemer corneliusroemer changed the title chore(website): set node version in dockerfile through arg chore(website): set node version in dockerfile through arg, align with nvmrc, bump to 22 May 9, 2024
@corneliusroemer corneliusroemer added the review please PR waiting for final review label May 9, 2024
@corneliusroemer corneliusroemer enabled auto-merge (squash) May 10, 2024 02:17
@corneliusroemer corneliusroemer merged commit 10fd46a into main May 10, 2024
12 checks passed
@corneliusroemer corneliusroemer deleted the node-version-docker branch May 10, 2024 08:22
corneliusroemer added a commit that referenced this pull request May 10, 2024
@corneliusroemer
chore(website): set node version in dockerfile through arg, align wit…
75c40e2 
…h nvmrc, bump to 22 (#1841)

(cherry picked from commit 10fd46a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson approved these changes

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd review please PR waiting for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @theosanderson