Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(keycloakify): slight refactor of version targeting #3323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corneliusroemer
Copy link
Contributor

Using the vitest.config.ts route means we notice more quickly (through ts errors) if something in the interface changes.

resolves #

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig
Copy link
Contributor

fhennig commented Dec 9, 2024

Looks good to me in principle.

(There was a failed test, I rebased it).

Using the vitest.config.ts route means we notice more quickly (through ts errors) if something in the interface changes.
@fhennig fhennig force-pushed the keycloakify-target branch from 3747288 to 3310bd0 Compare December 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants