Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): migrate to eslint 9, fix linter issues where reasonably possible #3450

Merged
merged 30 commits into from
Dec 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7e4b27d
wip eslint 9
fengelniederhammer Dec 17, 2024
666a540
fix some stuff
fengelniederhammer Dec 17, 2024
d26056d
fix some more stuff
fengelniederhammer Dec 17, 2024
a14b9b9
slightly fix result usage
fengelniederhammer Dec 17, 2024
a48b821
fix
fengelniederhammer Dec 17, 2024
7c6d3ae
don't fix it...
fengelniederhammer Dec 17, 2024
8ac3dca
don't even attempt to fix it
fengelniederhammer Dec 17, 2024
2499120
don't even attempt to fix it
fengelniederhammer Dec 17, 2024
1b0fbaf
ignore more anys
fengelniederhammer Dec 17, 2024
c4cb79f
don't fix more stuff
fengelniederhammer Dec 17, 2024
7fed1ed
disable false positive
fengelniederhammer Dec 17, 2024
78700fe
ignore more anys, this should be fixed separately
fengelniederhammer Dec 17, 2024
6296b08
no useless class
fengelniederhammer Dec 17, 2024
ce56a33
ignore more any
fengelniederhammer Dec 17, 2024
ea81479
another useless class
fengelniederhammer Dec 17, 2024
0eaab8f
ignore some lints in error handling
fengelniederhammer Dec 17, 2024
32f787d
fix some stuff
fengelniederhammer Dec 17, 2024
b64a99f
fix
fengelniederhammer Dec 17, 2024
fed004e
I don't know about this one...
fengelniederhammer Dec 17, 2024
6f06e25
fix
fengelniederhammer Dec 17, 2024
e5f5256
fix
fengelniederhammer Dec 17, 2024
8b074c7
fix
fengelniederhammer Dec 17, 2024
933469c
fix
fengelniederhammer Dec 17, 2024
fa6bbbe
fix
fengelniederhammer Dec 17, 2024
5c8e196
fix
fengelniederhammer Dec 17, 2024
a3237a0
fix it more
fengelniederhammer Dec 17, 2024
e2e1590
fix it more
fengelniederhammer Dec 17, 2024
32e461a
try dev server test fix
fengelniederhammer Dec 17, 2024
e538614
fix env variable name
fengelniederhammer Dec 17, 2024
31f2401
reference issue in TODOs
fengelniederhammer Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ignore more anys, this should be fixed separately
  • Loading branch information
fengelniederhammer committed Dec 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 78700fe70d7af154ed3a1aeb53b96c2c31e5725a
1 change: 1 addition & 0 deletions website/eslint.config.js
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ const disableFromTypescriptEsLint = {
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-redundant-type-constituents': 'off',
'@typescript-eslint/no-dynamic-delete': 'off',
};

const typescriptEslintConfig = {
2 changes: 1 addition & 1 deletion website/src/components/SearchPage/SearchFullUI.tsx
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@ const buildSequenceCountText = (totalSequences: number | undefined, oldCount: nu
return `Search returned ${formattedCount} sequence${pluralSuffix}`;
};

/* eslint-disable @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-dynamic-delete, @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return -- this component is a mess a needs to be refactored */
/* eslint-disable @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return -- this component is a mess a needs to be refactored */
export const InnerSearchFullUI = ({
accessToken,
referenceGenomesSequenceNames,
4 changes: 3 additions & 1 deletion website/src/utils/search.ts
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@ const getFieldOrColumnVisibilitiesFromQuery = (
if (field.rangeOverlapSearch) {
fieldName = field.rangeOverlapSearch.rangeName;
}
visibilities.set(fieldName, initiallyVisibleAccessor(field) === true);
visibilities.set(fieldName, initiallyVisibleAccessor(field));
});

const visibilityKeys = Object.keys(state).filter((key) => key.startsWith(visibilityPrefix));
@@ -187,6 +187,7 @@ export const consolidateGroupedFields = (filters: MetadataFilter[]): Consolidate
return fieldList;
};

/* eslint-disable @typescript-eslint/no-explicit-any -- fix me, use proper types */
export const getFieldValuesFromQuery = (
state: Record<string, string>,
hiddenFieldValues: Record<string, any>,
@@ -233,6 +234,7 @@ export const getLapisSearchParameters = (
referenceGenomesSequenceNames: ReferenceGenomesSequenceNames,
schema: Schema,
): Record<string, any> => {
/* eslint-enable @typescript-eslint/no-explicit-any */
const expandedSchema = getMetadataSchemaWithExpandedRanges(schema.metadata);

const sequenceFilters = Object.fromEntries(