Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for pre 3.6 Python versions (give error during installation) #1243

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Jan 24, 2020

Future releases will just not show support for these versions (so they wont be installed by pip), but this way we can show users what to do instead of just giving them an old package.

Solves #1120

…ns. Future releases will just not show support for these versions (so they wont be installed by pip), but this way we can show users what to do instead of just giving them an old package.
…. maybe it was because I did pip install -e...)
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #1243 into master will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1243     +/-   ##
=========================================
- Coverage   78.44%   77.24%   -1.2%     
=========================================
  Files          20       20             
  Lines        2004     2004             
  Branches      316      316             
=========================================
- Hits         1572     1548     -24     
- Misses        354      374     +20     
- Partials       78       82      +4
Impacted Files Coverage Δ
locust/util/exception_handler.py 78.94% <0%> (-15.79%) ⬇️
locust/util/deprecation.py 75% <0%> (-10%) ⬇️
locust/contrib/fasthttp.py 87.42% <0%> (-3.43%) ⬇️
locust/core.py 91.35% <0%> (-1.65%) ⬇️
locust/web.py 87.59% <0%> (-1.46%) ⬇️
locust/main.py 33.06% <0%> (-1.23%) ⬇️
locust/runners.py 73.44% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576f7ea...873523a. Read the comment docs.

@cyberw
Copy link
Collaborator Author

cyberw commented Jan 24, 2020

I'm trying to figure out what is wrong with the docker build, but failing miserably...

…the "ValueError: Egg metadata expected at build/....egg-info but not found" error during install.
@cyberw cyberw changed the title Give error during installation on unsupported (pre 3.6) Python versions Drop support for pre 3.6 Python versions (give error during installation) Jan 24, 2020
@cyberw cyberw merged commit 798156e into master Jan 28, 2020
@cyberw cyberw deleted the Drop-support-for-pre-3.6-python-versions-(give-users-an-error-message-during-installation) branch January 28, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant