Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework quickstart documentation and update some documentation for 1.0 #1384

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented May 19, 2020

Also update some UI text.

cyberw added 2 commits May 19, 2020 11:27
…s important things, etc). Moved quickstart example code into separate locustfile. Update some comments for 1.0.
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@06266b2). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1384   +/-   ##
=========================================
  Coverage          ?   79.91%           
=========================================
  Files             ?       26           
  Lines             ?     2459           
  Branches          ?      410           
=========================================
  Hits              ?     1965           
  Misses            ?      394           
  Partials          ?      100           
Impacted Files Coverage Δ
locust/main.py 21.78% <0.00%> (ø)
locust/user/task.py 95.68% <ø> (ø)
locust/user/users.py 95.58% <ø> (ø)
locust/user/wait_time.py 100.00% <ø> (ø)
locust/util/timespan.py 87.50% <0.00%> (ø)
locust/exception.py 100.00% <0.00%> (ø)
locust/argument_parser.py 76.14% <0.00%> (ø)
locust/user/__init__.py 100.00% <0.00%> (ø)
locust/log.py 61.11% <0.00%> (ø)
locust/web.py 91.25% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06266b2...7cd00ea. Read the comment docs.

Copy link
Member

@heyman heyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a bunch of inline comments. There's some nice improvements across the PR, but I don't agree with some of the changes to the Quickstart docs.

docs/quickstart.rst Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
docs/writing-a-locustfile.rst Show resolved Hide resolved
docs/writing-a-locustfile.rst Show resolved Hide resolved
examples/nested_inline_tasksets.py Outdated Show resolved Hide resolved
locust/main.py Show resolved Hide resolved
locust/user/task.py Outdated Show resolved Hide resolved
locust/user/wait_time.py Outdated Show resolved Hide resolved
@heyman heyman merged commit 6247f68 into master May 22, 2020
@cyberw cyberw deleted the rework-quickstart-documentation-and-update-some-documentation-for-1.0 branch March 22, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants