Base Locust Docker image on non-alpine python image #1435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Locust use the
python:3.8
docker image instead ofpython:3.8-alpine
as the base image.The reason for this is that it'll make it possible to
pip install ...
most PyPI packages out of the box, which should be a very common thing to do in project specific docker images.It comes with a ~900 MB cost in total image size, though I think the
python:3.8
image should be a very common base image to already have pulled, in which case there will effectively be no higher disk usage, and I think it makes sense to prioritize developer convenience and happiness over disk usage.This is what the description at the official docker python repo says about the
python:3.8
image:We could consider maintaining two branches of docker images (
locustio/locust
andlocustio/locust-alpine
), but I don't think it's worth the extra maintenance work.We would have to bump the Locust version to 1.1 if we release this, since it might break end-users custom docker images (the fixes should be very easy though, and mostly consist of removing a bunch of lines no longer needed from their Dockerfiles).