Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 things to .gitignore #1498

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Add 2 things to .gitignore #1498

merged 1 commit into from
Aug 13, 2020

Conversation

max-rocket-internet
Copy link
Contributor

Since it looks like we're gonna keep the messy formatting then I think we need to ignore .editorconfig 🙂

Also adding __pycache__ as it shows these directories in a colour as if they would be committed by git (at least in Atom) and this is a little confusing:

Screen Shot 2020-08-03 at 17 17 46

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1498 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   81.44%   81.40%   -0.05%     
==========================================
  Files          27       27              
  Lines        2388     2388              
  Branches      367      367              
==========================================
- Hits         1945     1944       -1     
  Misses        352      352              
- Partials       91       92       +1     
Impacted Files Coverage Δ
locust/user/task.py 95.67% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b89d7...ec0ba78. Read the comment docs.

@heyman
Copy link
Member

heyman commented Aug 3, 2020

__pycache__ sounds good, though I can recommend that you add it to your global .gitignore.

Maybe it would be better to add the .editorconfig with the project specific settings to the project instead?

@max-rocket-internet
Copy link
Contributor Author

Maybe it would be better to add the .editorconfig with the project specific settings to the project instead?

I never used it until now TBH. Do people put custom stuff in these files? I just added:

root = true

[*]
trim_trailing_whitespace = false
insert_final_newline = false

@cyberw cyberw merged commit 4833395 into locustio:master Aug 13, 2020
@max-rocket-internet max-rocket-internet deleted the update_gitignore branch August 14, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants