Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type hints #1582

Merged
merged 6 commits into from
Oct 1, 2020
Merged

Add more type hints #1582

merged 6 commits into from
Oct 1, 2020

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Oct 1, 2020

fixes #1260

cyberw and others added 6 commits October 1, 2020 16:34
…ed from (it used to fail if you were running python3 -m pytest from inside the locust subfolder)
…e add a type hint. I was forced to move FastHttpUser to be after FastHttpSession for the hint to work.
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1582 into master will increase coverage by 0.47%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   81.64%   82.12%   +0.47%     
==========================================
  Files          28       28              
  Lines        2594     2596       +2     
  Branches      395      395              
==========================================
+ Hits         2118     2132      +14     
+ Misses        378      367      -11     
+ Partials       98       97       -1     
Impacted Files Coverage Δ
locust/contrib/fasthttp.py 85.84% <73.33%> (+0.47%) ⬆️
locust/env.py 96.82% <100.00%> (+0.10%) ⬆️
locust/shape.py 90.90% <100.00%> (+0.90%) ⬆️
locust/user/task.py 95.74% <100.00%> (+0.02%) ⬆️
locust/user/users.py 95.71% <100.00%> (-0.12%) ⬇️
locust/stats.py 90.08% <0.00%> (+0.20%) ⬆️
locust/runners.py 83.42% <0.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd9367...c8299f0. Read the comment docs.

@cyberw cyberw merged commit 32de954 into master Oct 1, 2020
@cyberw cyberw deleted the add-more-type-hints branch March 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hinting for common functions
1 participant