Shutdown workers when using LoadTestShape and headless mode

[max-rocket-internet]

Resolves #1653

[max-rocket-internet]

@cyberw why aren't the tests running?

[cyberw]

Because travis freaked out about their free/open source tier. Heyman has reached out to them.

[cyberw]

Hmm.. I am lazy and didnt run the tests until after merging. So I had to fix an issue exposed by test_runners.py, but there seems to still be an issue with test_main.py (the commit above)

I tried adding "-L", "DEBUG", in that test, because I think Quitting... is only printed then, but that does not seem to be enough...

[max-rocket-internet]

Yeah I didn't run any tests as they were not working locally and the travis tests weren't working either. I didn't expect you to merge the PR until at least the travis tests were run 🙂

Shall I open another PR to fix the tests?

[cyberw]

Ah, I got a little bit ahead of myself :)

Yes, if you can open a new PR with a fix that would be great.

[aek]

I have created this one for improve tests:
#1685

[cyberw]

ping @heyman this is the PR we're waiting for a fix for :)

[heyman]

AFAICT we only log the Quitting... message when we run in master mode, and since the test runs locust with a LocalRunner it'll fail. Maybe we can just remove that check (https://github.com/locustio/locust/pull/1683/files#diff-81a8e34f7c9a9b06d20ff25a8b8d6f6fe983707f8ba66780659df4fe4fffa2aaR282)?

[heyman]

I removed the check in cb56d64 (to get the Github Actions CI to work).

[max-rocket-internet]

Sorry, I've been super busy. So this is resolved now I see by just reverting my change to the test. OK cool 👍