fix --html report in web mode

[uddmorningsun]

If locust is started by --headful argument(web mode), main_greenlet.join() will serve forever. get_html_report will be inaccessable.

If running locust will be CTRL+C, get_html_report will not be received by catching the exception.

In order to keep simple, get_html_report is dealt with shutdown() according to --html argument value.

Signed-off-by: Chenyang Yan memory.yancy@gmail.com

Edit: Fixes #1944

[cyberw]

command line help text is a bit verbose, "Store HTML report to file path specified" should be enough, does that sound ok?

If you havent already, please test this in "regular" mode (run a test from the gui, stop it from the gui) as well as using --autostart

[uddmorningsun]

"Store HTML report to file path specified"

It's OK

I've forgot stop button in web ui:sweat_smile:. But there's a problem in locust.web.py:WebUI.stop, only runner is stopped, but there has always been found greenlet process. If sending /stop, you will see process hang up. Maybe add self.greenlet.kill(block=True)?

And, what do you think about dealing with ctrl-c for get_html_report

[cyberw]

Good question. Unfortunately I'm not completely up to speed on those things, and I dont have time to dig into it, so your guess is as good as mine :) (I will of course be happy to review, once it is working)

but there has always been found greenlet process

I dont understand that sentence...

[uddmorningsun]

Sorry, my broken English😅 It means there's a bug with /stop in web.py. Process will hang up in terminal window while clicking stop button in web ui.

I updated, could you help me review it?

[cyberw]

Hmm... I'm worried this might cause issues with repeated gui runs. Have you tried that?

[uddmorningsun]

What does meaning of repeated gui runs? I guess that different --web-port to run?

I have tried that it's normal to start again after sending the stop button, even for different ports.

[cyberw]

I have tried that it's normal to start again after sending the stop button, even for different ports.

That's all I meant :) Thanks!

[uddmorningsun]

Oops, it's my fault 😐 for the issue #1995. Again, I understood the meaning of with repeated gui runs, run multiple tests in one running locust environment.

[cyberw]

Yea, that didnt work very well, causing the issue #1995 I'm reverting the greenlet killing part.

[chy8803]

Yea, that didnt work very well, causing the issue #1995 I'm reverting the greenlet killing part.

This PR caused the master pod restarting and resetting the data. After clicking Stop button UI, /stats/report becomes unaccessible since the process is stopped.