New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warnings from the Web UI Tests #2499

Merged

cyberw merged 4 commits into locustio:master from andrewbaldwin44:bugfix/test-warnings

Dec 3, 2023

Collaborator

andrewbaldwin44 commented Dec 3, 2023 •

edited

Loading

Add a config to vitest that allows for using after / before / afterAll / beforeAll hooks (and thus silences this warning)
Add a width and height to the e-charts container so that it doesn't output any warning either
Fix warnings that recommends using act when a component re-renders
The tests also reveled that addSpaceToChartsBetweenTests was using payload[0], which isn't correct. This is changed to a simple empty value

andrewbaldwin44 added 4 commits

December 3, 2023 17:28


          Fix addSpaceToChartsBetweenTests time logic

9e67ff7


          Fix globals warnings

c14d4e2


          Fix echarts warning

0c7bed0


          Fix use act warnings

3faf1e0

Collaborator

cyberw commented Dec 3, 2023

Nice!

cyberw merged commit 21453a8 into locustio:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet