Add iter_lines Method to FastHttpSession Class #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
在 FastHttpSession 类中添加 iter_lines 方法
Reuses the logic of the request method and provides type annotations to enhance code readability and consistency.
fix: Remove trailing whitespace from blank line in fasthttp.py to comply with PEP 8
fix: fasthttp.py to comply with PEP 8
|
Looks good, but can you add a test case too? (in test_fasthttp.py) |
|
The lack of an endpoint that can return streaming data or a simulated response might be the reason for the test failure. |
|
Can you use the /streaming/:int: endpoint defined here? locust/locust/test/testcases.py Line 119 in 81116b2 |
I have just completed the implementation of the iter_lines method in FastHttpSession and successfully passed all related tests. I look forward to your review and feedback on this part of the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、Add iter_lines Method to FastHttpSession Class
2、fix: Remove trailing whitespace from blank line in fasthttp.py to comply with PEP 8
Fixes #3018