Rap 614 use setuptools scm #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e what we want. This is needed, because `setuptools` when used in combination with `setuptools_scm` adds all the files under revision control in the source distribution. We do not want that.
Only adding `setuptools_scm` already required changes to `MANIFEST.in` to avoid that all the files under version control are put into the source distribution. TODO: * Actually start using automatic versioning * Move all project settings from `setup.py` to `pyproject.toml`
Make room for automatically generated `_version.py` file by renaming the existing file.
This still needs some significant cleanup, but at least this appears to work.
Automatic versioning only works if version is _not_ also set in `setup.py`. Also added `bdsf/_version.py` to the `.gitignore` file, because is should *never* be put under version control anymore.
All project settings have been moved from `setup.py` to `pyproject.toml`, except for a few that need to be set in the call to `setup()` in `setup.py`, as required by `scikit-build`.
Added a comment in `setup.py`, explaining why we need to pass some configuration options as arguments to `setup()`, instead of providing them in `pyproject.toml`.
tammojan
approved these changes
May 6, 2024
|
The issue is not with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
setuptools_scmto do automatic versioning.Since
setuptools_scmrecommends to usepyproject.tomlinstead ofsetup.py, most setting were move fromsetup.pytopyproject.toml. However,scikit-buildrequires a few settings to be set insetup.py. So these were retained.