fix(git): add support for credential.useHttpPath
#1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkneis
reviewed
Jan 13, 2025
bkneis
approved these changes
Jan 13, 2025
pascalbreuninger
force-pushed
the
fix/POD-1227-use-http-path
branch
from
405919a to
27d83fc
Compare
In some scenarios the host machines git config sets `credential.useHttpPath=true` but the git config in either the agent or actual workspace doesn't. Until now this would break git credential forwarding because we wouldn't provide the `path` component to the machines git credential helper.
pascalbreuninger
force-pushed
the
fix/POD-1227-use-http-path
branch
from
27d83fc to
d86af68
Compare
janekbaraniewski
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios the host machines git config sets
credential.useHttpPath=truebut the git config in either the agent or actual workspace doesn't.Until now this would break git credential forwarding because we wouldn't provide the
pathcomponent to the machines git credential helper.