Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/create pro workspace trailing slash #1578

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix/create pro workspace trailing slash #1578

merged 2 commits into from
Jan 20, 2025

Conversation

pascalbreuninger
Copy link
Member

  • chore(pro): hide 'try to enable debug logs' line if pro command has been executed by DevPod Desktop.
  • fix(cli): remove trailing / from workspace source

@pascalbreuninger
chore(pro): hide 'try to enable debug logs' line if pro command has been
c4e603a 
executed by DevPod Desktop.

These commands are intended for internal usage and shouldn't print
anything user facing without explicitly requesting
@pascalbreuninger pascalbreuninger requested a review from a team January 20, 2025 07:57
@pascalbreuninger pascalbreuninger force-pushed the fix/create-pro-workspace-trailing-slash branch 2 times, most recently from eb76157 to 25649d9 Compare January 20, 2025 11:35
bkneis
bkneis approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice addition of the unit tests

@pascalbreuninger pascalbreuninger force-pushed the fix/create-pro-workspace-trailing-slash branch from 25649d9 to 1cfbca0 Compare January 20, 2025 13:30
@pascalbreuninger pascalbreuninger merged commit a84e608 into loft-sh:main Jan 20, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkneis bkneis bkneis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalbreuninger @bkneis