fix(pro): local folder upload works properly now with pro #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that we correctly put the uploaded local folder under the workspace directory /var/lib/loft/devpod/$WORKSPACE_ID/agent/.. but when we established the SSH connection we attempted to create the actual local workspace folder on the runner side. Because we usually only have write access to /var/lib/loft remotely this causes permission issues and `devpod ssh` to fail.
janekbaraniewski
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we correctly put the uploaded local folder under
the workspace directory /var/lib/loft/devpod/$WORKSPACE_ID/agent/.. but
when we established the SSH connection we attempted to create the actual
local workspace folder on the runner side.
Because we usually only have write access to /var/lib/loft remotely this
causes permission issues and
devpod sshto fail.