Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding info about stateful set (#207) #333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Piotr1215
Copy link
Contributor

@Piotr1215 Piotr1215 commented Oct 25, 2024

Closes DOC-207

Docs Preview

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for vcluster-docs-site ready!

Name Link
🔨 Latest commit edc14ed
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/6744747dc2320a000833eafd
😎 Deploy Preview https://deploy-preview-333--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

:::info vCluster Control Plane
The vCluster `my-cluster-0` pod is also known as the vCluster control plane.

A virtual cluster is deployed as a
[StatefulSet](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the use case of when this happens, but there are a handful of options that change the control plane pods from a statefulset to a deployment.

@FabianKramm Can you clarify those use cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also related

When deploying vCluster in HA mode, I'm getting deployment and statefulset rather than 2 statefulsets. Is this a bug or we should adjust the docs (and vcluster.yaml) have stateful set for etcd and deployment for vCluster?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vcluster.yaml won't change (as I've already discussed that), but more that we should adjust the docs.

In default use case it deploys a statefulSet, but there are use cases when it becomes a deployment. @Piotr1215 Can you follow up with Fabian to understand when it's statefulset vs. deployment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically whenever no local persistent storage is needed the statefulset becomes a regular deployment. This is the case for external backing stores such as external etcd or external database or if persistence is disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FabianKramm , adjusted the description.

Signed-off-by: Piotr Zaniewski <piotr.zaniewski@loft.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants