-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding info about stateful set (#207) #333
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
:::info vCluster Control Plane | ||
The vCluster `my-cluster-0` pod is also known as the vCluster control plane. | ||
|
||
A virtual cluster is deployed as a | ||
[StatefulSet](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot the use case of when this happens, but there are a handful of options that change the control plane pods from a statefulset to a deployment.
@FabianKramm Can you clarify those use cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also related
When deploying vCluster in HA mode, I'm getting deployment and statefulset rather than 2 statefulsets. Is this a bug or we should adjust the docs (and vcluster.yaml) have stateful set for etcd
and deployment for vCluster
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vcluster.yaml won't change (as I've already discussed that), but more that we should adjust the docs.
In default use case it deploys a statefulSet, but there are use cases when it becomes a deployment. @Piotr1215 Can you follow up with Fabian to understand when it's statefulset vs. deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically whenever no local persistent storage is needed the statefulset becomes a regular deployment. This is the case for external backing stores such as external etcd or external database or if persistence is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FabianKramm , adjusted the description.
ecfbee0
to
5cfa841
Compare
Signed-off-by: Piotr Zaniewski <piotr.zaniewski@loft.sh>
5cfa841
to
edc14ed
Compare
Closes DOC-207
Docs Preview