fix: update platform add command to reference the platform instead of loft #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
requested changes
Sep 19, 2024
| @@ -70,7 +70,7 @@ vcluster platform add cluster my-cluster | |||
| }, | |||
| } | |||
|
|
|||
| c.Flags().StringVar(&cmd.Namespace, "namespace", "loft", "The namespace to generate the service account in. The namespace will be created if it does not exist") | |||
| c.Flags().StringVar(&cmd.Namespace, "namespace", "vcluster-platform", "The namespace to generate the service account in. The namespace will be created if it does not exist") | |||
There was a problem hiding this comment.
This breaks a lot of things as the Cluster Object is not updated with the namespace, I think #2147 does this better
There was a problem hiding this comment.
I forgot about this when making this PR. I'll remove it from my PR and see if @zerbitx can help fix this one since I've found it.
deniseschannon
force-pushed
the
loft-ref
branch
from
d048af5 to
b881a08
Compare
FabianKramm
approved these changes
Sep 19, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Sep 19, 2024
[v0.20] Merge pull request #2155 from deniseschannon/loft-ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)part of #eng-4516
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster platform add referenced
loftinstead of the new platform references.What else do we need to know?