Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4867: Fixes platform create output so it prints internal vcluster create command instead of external #2221

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

cbron
Copy link
Contributor

@cbron cbron commented Oct 10, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve?
resolves ENG-4867

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster platform start command printed the wrong type of vcluster create command

vcluster-create command instead of external.
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b71de4
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6708355b2b59a20008c885b6

@cbron cbron requested a review from a team October 10, 2024 23:35
Copy link
Contributor

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@deniseschannon deniseschannon merged commit aabc672 into loft-sh:main Oct 10, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants