Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix host to virtual service selector syncing #2440

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

zerbitx
Copy link
Contributor

@zerbitx zerbitx commented Jan 31, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

This brings the selector syncing inline with the CopyBidirectional logic.

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #ENG-5654

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where the host service selector should have been synced to the virtual, but it was nullified to match the virtual instead.

What else do we need to know?

Example of what occurred

  • Selector was removed from host service
  • The change was synced down to the virtual cluster removing it
  • The selector was added back to the host service
  • The check here was true since the host hadn't changed, and HostLabelsMap returned nil since the vCluster selector was nil.

@zerbitx zerbitx requested a review from a team January 31, 2025 18:35
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1451697
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/679d17f4eef7710009c40c8d

Copy link
Contributor

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loft-bot
Copy link

💚 All backports created successfully

Status Branch Result
v0.21
v0.22

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants