Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing and download completions cli bug #240

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Conversation

kxtran
Copy link
Collaborator

@kxtran kxtran commented Jul 31, 2024

Description

  • Keep file open while writing file to it improves the latency.
  • Fix the bugs with listing completions and downloading completions.

Opening file each time duration:

Downloaded 10 completions so far to completions.jsonl.
Downloaded 20 completions so far to completions.jsonl.
Download total completions: 20. Saved to completions.jsonl
Total write time: 9985.4531 ms

Keep the file open:

Downloaded 10 completions so far to completions.jsonl.
Downloaded 20 completions so far to completions.jsonl.
Download total completions: 20. Saved to completions.jsonl
Total write time: 1.5178 ms
Screen.Recording.2024-07-31.at.18.59.42.mov

@kxtran kxtran force-pushed the kt/listing-completions-bug branch from 01e5016 to c9bd602 Compare July 31, 2024 21:40
@kxtran kxtran changed the title Fix listing completions bug Fix listing and download completions cli bug Jul 31, 2024
@kxtran kxtran force-pushed the kt/listing-completions-bug branch from 52f485d to 0530e07 Compare July 31, 2024 21:46
@kxtran kxtran requested a review from wenzhe-log10 July 31, 2024 22:18
@kxtran kxtran merged commit 9626930 into main Jul 31, 2024
2 checks passed
@kxtran kxtran deleted the kt/listing-completions-bug branch July 31, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants