Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psort-studentpc1-services end-to-end test failing with QueueFull #3001

Closed
joachimmetz opened this issue Jun 4, 2020 · 6 comments · Fixed by #3006
Closed

psort-studentpc1-services end-to-end test failing with QueueFull #3001

joachimmetz opened this issue Jun 4, 2020 · 6 comments · Fixed by #3006
Assignees
Labels
analysis Issue related to analysis plugins bug

Comments

@joachimmetz
Copy link
Member

2020-06-04 09:30:46,985 [INFO] (MainProcess) PID:4370 <data_location> Determined data location: /tmp/workspace/psort-linux-services/data
Traceback (most recent call last):
  File "./tools/psort.py", line 95, in <module>
    if not Main():
  File "./tools/psort.py", line 72, in Main
    tool.ProcessStorage()
  File "/tmp/workspace/psort-linux-services/plaso/cli/psort_tool.py", line 554, in ProcessStorage
    worker_memory_limit=self._worker_memory_limit)
  File "/tmp/workspace/psort-linux-services/plaso/multi_processing/psort.py", line 909, in AnalyzeEvents
    storage_writer, analysis_plugins, event_filter=event_filter)
  File "/tmp/workspace/psort-linux-services/plaso/multi_processing/psort.py", line 281, in _AnalyzeEvents
    event_queue.PushItem((event, event_data))
  File "/tmp/workspace/psort-linux-services/plaso/engine/zeromq_queue.py", line 457, in PushItem
    raise errors.QueueFull
plaso.lib.errors.QueueFull
@joachimmetz joachimmetz added testing needs closer look Issue that requires further analysis by a maintainer labels Jun 4, 2020
@Onager Onager self-assigned this Jun 5, 2020
@Onager
Copy link
Contributor

Onager commented Jun 5, 2020

This seems to be due to the windows_service plugin exit prematurely. Looking into why this is.

@Onager
Copy link
Contributor

Onager commented Jun 5, 2020

It looks like this is failing because it's being fed an WindowsRegistryServiceEventData that has no service_dll attribute.

I don't understand what could be removing the attribute from the EventData, I'd expect it to be set to None.

@Onager
Copy link
Contributor

Onager commented Jun 5, 2020

It's actually not a WindowsRegistryServiceEventData, it's just a regular EventData.

I assume there's something in the storage implementation or serializer that's deleting the attribute from the eventdata. The unittests are OK, and they use the FakeStorageWriter.

@Onager
Copy link
Contributor

Onager commented Jun 5, 2020

This is because GetAttributes in the attribute container interface skips all attributes that have a None value.

Onager added a commit to Onager/plaso that referenced this issue Jun 5, 2020
@Onager Onager linked a pull request Jun 5, 2020 that will close this issue
@Onager Onager added analysis Issue related to analysis plugins bug and removed needs closer look Issue that requires further analysis by a maintainer testing labels Jun 5, 2020
@joachimmetz
Copy link
Member Author

It's actually not a WindowsRegistryServiceEventData, it's just a regular EventData.

WindowsRegistryServiceEventData is the only event data that defines service_dll

@joachimmetz
Copy link
Member Author

End to end tests started passing again on Jun 22, but failed on Jun 28. Created #3145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Issue related to analysis plugins bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants