-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated systemd journal construct-based plugin to use dtfabric #1893 #2124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
=========================================
+ Coverage 85.08% 85.1% +0.01%
=========================================
Files 450 452 +2
Lines 31642 31762 +120
=========================================
+ Hits 26923 27031 +108
- Misses 4719 4731 +12
Continue to review full report at Codecov.
|
Significantly improved performance of refactored parser, having a look if I can squeeze out more. |
Added @rgayon for a look at this too, since he's familiar with the format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Migrated systemd journal construct-based plugin to use dtfabric #1893
Note to reviewer current implementation is slow, looking into optimization.