Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated systemd journal construct-based plugin to use dtfabric #1893 #2124

Merged
merged 6 commits into from
Sep 8, 2018

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Sep 2, 2018

Migrated systemd journal construct-based plugin to use dtfabric #1893

Note to reviewer current implementation is slow, looking into optimization.

@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #2124 into master will increase coverage by 0.01%.
The diff coverage is 83.89%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2124      +/-   ##
=========================================
+ Coverage   85.08%   85.1%   +0.01%     
=========================================
  Files         450     452       +2     
  Lines       31642   31762     +120     
=========================================
+ Hits        26923   27031     +108     
- Misses       4719    4731      +12
Impacted Files Coverage Δ
plaso/parsers/dtfabric_parser.py 98.78% <100%> (+0.06%) ⬆️
plaso/parsers/systemd_journal.py 86.48% <83.18%> (-9.35%) ⬇️
plaso/parsers/text_parser.py 86.01% <0%> (ø) ⬆️
plaso/formatters/apache_access.py 100% <0%> (ø)
plaso/parsers/apache_access.py 89.04% <0%> (ø)
plaso/parsers/santa.py 96.1% <0%> (+0.02%) ⬆️
plaso/parsers/mac_keychain.py 88.82% <0%> (+0.1%) ⬆️
plaso/storage/sqlite/sqlite_file.py 88.75% <0%> (+0.23%) ⬆️
plaso/storage/interface.py 78.19% <0%> (+0.41%) ⬆️
plaso/multi_processing/psort.py 77.37% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d904c...3b98299. Read the comment docs.

@joachimmetz
Copy link
Member Author

Significantly improved performance of refactored parser, having a look if I can squeeze out more.

@Onager Onager requested a review from rgayon September 6, 2018 15:16
@Onager
Copy link
Contributor

Onager commented Sep 6, 2018

Added @rgayon for a look at this too, since he's familiar with the format

Copy link
Contributor

@rgayon rgayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Onager Onager merged commit f5d8daa into log2timeline:master Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants