Implemented SQLite parser plugin for android's turbo.db database #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I'll take a look as time permits. |
|
rebased with upstream for failing CI tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4880 +/- ##
==========================================
+ Coverage 85.10% 85.11% +0.01%
==========================================
Files 428 429 +1
Lines 38836 38865 +29
==========================================
+ Hits 33051 33080 +29
Misses 5785 5785 ☔ View full report in Codecov by Sentry. |
joachimmetz
reviewed
May 5, 2024
| self.assertEqual(number_of_warnings, 0) | ||
|
|
||
| expected_event_values = { | ||
| 'battery_level': 99, |
There was a problem hiding this comment.
style nit: 4 space continuation indentation.
joachimmetz
reviewed
May 5, 2024
| @@ -12,6 +12,17 @@ short_source: 'LOG' | |||
| source: 'Android App Usage' | |||
| --- | |||
| type: 'conditional' | |||
| data_type: 'android:event:battery' | |||
| message: | |||
There was a problem hiding this comment.
given that both battery_saver and charge_type are enumerations, let's add their values here
|
@rick-slin a couple of small nits, I'll push some additional changes shortly to address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of pull request
Implemented SQLite parser plugin for android's turbo.db database
Description:
The turbo.db database from Android devices logs the battery level for the device over time.
Notes:
All contributions to Plaso undergo code review.
This makes sure that the code has appropriate test coverage and conforms to the
Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: