Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fs.appendFileSync should use flag instead of flags #141

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: fs.appendFileSync should use flag instead of flags #141

merged 1 commit into from
May 23, 2022

Conversation

lamweili
Copy link
Contributor

Strangely, fs.appendFileSync uses flag but fs.createWriteStream uses flags.

It's somewhat inconsistent throughout the Node.js documentation:
https://nodejs.org/api/fs.html

@lamweili lamweili added the bug Something isn't working label May 23, 2022
@lamweili lamweili added this to the 3.1.1 milestone May 23, 2022
@lamweili lamweili merged commit 09c84c9 into master May 23, 2022
@lamweili lamweili deleted the fixes-fs.appendFileSync branch May 23, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
1 participant
@lamweili