Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]暴露formatter时FILENAME_SEP参数进行配置传入 #67

Merged
merged 2 commits into from
Jan 12, 2022
Merged

[feat]暴露formatter时FILENAME_SEP参数进行配置传入 #67

merged 2 commits into from
Jan 12, 2022

Conversation

laidaxian
Copy link

[feat]can configuration FILENAME_SEP parameter when exposing formatter module

lamweili
lamweili reviewed Jan 6, 2022
View reviewed changes
Copy link
Contributor

@lamweili lamweili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed that a logic has been changed, would require some clarification.

lib/RollingFileWriteStream.js Outdated Show resolved Hide resolved
@lamweili lamweili added this to the 3.0.0 milestone Jan 12, 2022
@lamweili lamweili merged commit 4a620d0 into log4js-node:master Jan 12, 2022
@lamweili lamweili mentioned this pull request Jan 12, 2022
Merged
@lamweili lamweili mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamweili lamweili lamweili left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@laidaxian @lamweili @cvtetheboom