-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow for zero backups and zero daysToKeep #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lamweili
added a commit
to log4js-node/log4js-node
that referenced
this pull request
Jan 19, 2022
**Important** It is also to note the the file does not roll within itself (truncate its older entry for newer entry). It truncates all and appends only the new entry. ```javascript var rollers = require('streamroller'); var stream = new rollers.RollingFileStream('myfile', 6, 0); stream.write("abc"); // add as first row stream.write("def"); // add as second row stream.write("ghi"); // truncate all and add as first row stream.end(); ``` Output: ``` myfile - ghi ```
lamweili
added a commit
to log4js-node/log4js-node
that referenced
this pull request
Jan 19, 2022
**Important** It is also to note the file does not roll within itself (truncate its older entry for newer entry). It truncates all and appends only the new entry. ```javascript var rollers = require('streamroller'); var stream = new rollers.RollingFileStream('myfile', 6, 0); stream.write("abc"); // add as first row stream.write("def"); // add as second row stream.write("ghi"); // truncate all and add as first row stream.end(); ``` Output: ``` myfile - ghi ```
lamweili
added a commit
to log4js-node/log4js-node
that referenced
this pull request
Jan 19, 2022
allow for zero backup - log4js-node/streamroller#74
This was referenced Jan 20, 2022
This was referenced Dec 19, 2023
This was referenced Dec 19, 2023
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Public APIs:
RollingFileStream
backups
excludes the hot file (original behavior retained)filename.log.1filename.log.1
filename.log.1
filename.log.2
filename.log.1
filename.log.2
filename.log.3
DateRollingFileStream
daysToKeep
excludes the hot file (original behavior retained)(default)filename.log.2022-01-11filename.log.2022-01-10filename.log.2022-01-09filename.log.2022-01-11
filename.log.2022-01-11
filename.log.2022-01-10
filename.log.2022-01-11
filename.log.2022-01-10
filename.log.2022-01-09
Private APIs (only if used directly and not via public APIs):
RollingFileWriteStream
numToKeep
excludesincludes the hot file (new behavior)filename.log.1filename.log.1
filename.log.2filename.log.1
filename.log.2
filename.log.3Important
It is also to note the file does not roll within itself (truncate its older entry for newer entry).
It truncates all and appends only the new entry.
Output: